[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 3 Mar 2016 17:36:22 +0100
From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
To: David Daney <ddaney@...iumnetworks.com>
Cc: Rob Herring <robh+dt@...nel.org>,
David Daney <ddaney.cavm@...il.com>,
Will Deacon <will.deacon@....com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Frank Rowand <frowand.list@...il.com>,
Grant Likely <grant.likely@...aro.org>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Ganapatrao Kulkarni <gkulkarni@...iumnetworks.com>,
Robert Richter <rrichter@...ium.com>,
Matt Fleming <matt@...eblueprint.co.uk>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v13 4/6] arm64: Move unflatten_device_tree() call earlier.
On 3 March 2016 at 17:33, David Daney <ddaney@...iumnetworks.com> wrote:
> On 03/03/2016 05:47 AM, Rob Herring wrote:
>>
>> On Wed, Mar 2, 2016 at 4:56 PM, David Daney <ddaney.cavm@...il.com> wrote:
>>>
>>> From: David Daney <david.daney@...ium.com>
>>>
>>> In order to extract NUMA information from the device tree, we need to
>>> have the tree in its unflattened form.
>>>
>>> Move the call to unflatten_device_tree() into paging_init(). This
>>> puts it before the call to bootmem_init(), which is where the NUMA
>>> information is extracted.
>>
>>
>> Can't you just move up unflatten_device_tree in setup_arch rather than
>> hiding in paging_init?
>
>
> No.
>
> It must come *after* map_mem() and *before* bootmem_init(), both of which
> are done within paging_init().
>
> One option would be to split the things in paging_init() into two functions,
> and then do:
>
> .
> .
> .
> paging_init_first_part();
> if (acpi_disabled)
> unflatten_device_tree();
> paging_init_second_part();
> .
I think it makes more sense to move bootmem_init() to setup_arch() then
Powered by blists - more mailing lists