| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <1457075944-6959-1-git-send-email-a.hajda@samsung.com> Date: Fri, 04 Mar 2016 08:19:04 +0100 From: Andrzej Hajda <a.hajda@...sung.com> To: Giuseppe Cavallaro <peppe.cavallaro@...com>, netdev@...r.kernel.org Cc: Andrzej Hajda <a.hajda@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, linux-kernel@...r.kernel.org Subject: [PATCH] stmmac: Fix type of local variable in stmmac_xmit Variable entry holds result of jumbo_frm callback. It can be negative, so the variable should be signed. The patch changes also type of related first_entry variable to make code compact and coherent. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda <a.hajda@...sung.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4c5ce98..cd31a3c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1955,7 +1955,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) unsigned int nopaged_len = skb_headlen(skb); int i, csum_insertion = 0, is_jumbo = 0; int nfrags = skb_shinfo(skb)->nr_frags; - unsigned int entry, first_entry; + int entry, first_entry; struct dma_desc *desc, *first; unsigned int enh_desc; -- 1.9.1
Powered by blists - more mailing lists