linux-kernel - [PATCH] infiniband: hns: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Mar 2016 20:10:57 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"Wei Hu(Xavier)" <xavier.huwei@...wei.com>
Cc:	kbuild-all@...org, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com, jiri@...lanox.com,
	ogerlitz@...lanox.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	gongyangming@...wei.com, xiaokun@...wei.com,
	tangchaofei@...wei.com, oulijun@...wei.com, haifeng.wei@...wei.com,
	yisen.zhuang@...wei.com, yankejian@...wei.com,
	lisheng011@...wei.com, charles.chenxin@...wei.com,
	linuxarm@...wei.com
Subject: [PATCH] infiniband: hns: fix returnvar.cocci warnings

drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c:1562:5-8: Unneeded variable: "ret". Return "0" on line 1587


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Wei Hu(Xavier) <xavier.huwei@...wei.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

 hns_roce_v1_hw.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c
+++ b/drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c
@@ -1559,7 +1559,6 @@ int hns_roce_v1_req_notify_cq(struct ib_
 	struct hns_roce_cq *hr_cq = to_hr_cq(ibcq);
 	u32 notification_flag;
 	u32 doorbell[2];
-	int ret = 0;
 
 	notification_flag = (flags & IB_CQ_SOLICITED_MASK) == IB_CQ_SOLICITED ?
 		CQ_DB_REQ_NOT : CQ_DB_REQ_NOT_SOL;
@@ -1584,7 +1583,7 @@ int hns_roce_v1_req_notify_cq(struct ib_
 
 	hns_roce_write64_k(doorbell, hr_cq->cq_db_l);
 
-	return ret;
+	return 0;
 }
 
 static int hns_roce_v1_poll_one(