linux-kernel - Re: [PATCH] goldfish: Fix build error of missing ioremap on UM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1457106530.7064.52.camel@linux.intel.com>
Date:	Fri, 04 Mar 2016 15:48:50 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Jin Qian <jinqian@...roid.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Greg Hackmann <ghackmann@...gle.com>,
	Miodrag Dinic <miodrag.dinic@...tec.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] goldfish: Fix build error of missing ioremap on UM

On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote:
> Add missing HAS_IOMEM dependency to fix the allyesconfig build error
> on
> ARCH=um (for x86_64):
> 
> drivers/platform/goldfish/pdev_bus.c: In function
> ‘goldfish_pdev_bus_probe’:
> drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit
> declaration of function ‘ioremap’ [-Werror=implicit-function
> -declaration]
>   pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Reviewed-by: Alan Cox <alan@...ux.intel.com>

Thanks for that - I was trying to work out where that weird 0day
complaint was coming from.

Alan