linux-kernel - Re: [PATCH] Rename "trigger" reset reason "hw watchdog"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160304194017.GG6900@spo001.leaseweb.nl>
Date:	Fri, 4 Mar 2016 20:40:17 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Martyn Welch <martyn.welch@...labora.co.uk>
Cc:	Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Rename "trigger" reset reason "hw watchdog"

Hi Martyn,

> The Zodiac watchdog is implemented on a microcontoller. The reset reason
> currently labelled "trigger" is not to detect when the watchdog has
> triggered (as had been initially understood and suggested by the naming),
> but to inform the reader that the watchdog, which in fact has it's own
> hardware watchdog, has been reset because the hardware watchdog has
> triggered. Renaming to "hw watchdog".
> 
> Signed-off-by: Martyn Welch <martyn.welch@...labora.co.uk>
> ---
>  drivers/watchdog/ziirave_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index 0c7cb73..cbe373de 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -36,7 +36,7 @@
>  #define ZIIRAVE_STATE_OFF	0x1
>  #define ZIIRAVE_STATE_ON	0x2
>  
> -static char *ziirave_reasons[] = {"power cycle", "triggered", NULL, NULL,
> +static char *ziirave_reasons[] = {"power cycle", "hw watchdog", NULL, NULL,
>  				  "host request", NULL, "illegal configuration",
>  				  "illegal instruction", "illegal trap",
>  				  "unknown"};
> -- 
> 2.1.4
> 

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.