linux-kernel - Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160304233241.GA25079@intel.com>
Date:	Sat, 5 Mar 2016 01:32:41 +0200
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Peter Huewe <peterhuewe@....de>, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct
 device

On Thu, Feb 18, 2016 at 11:03:31AM -0700, Jason Gunthorpe wrote:
> > +	INIT_LIST_HEAD(&resources);
> > +	rc = acpi_dev_get_resources(device, &resources, crb_check_resource,
> > +				    priv);
> > +	if (rc < 0)
> > +		return rc;
> > +	acpi_dev_free_resource_list(&resources);
> 
> I wonder if the acpi_dev_free_resource_list is what kill's the
> resource name? Maybe that needs to be delayed until after the
> ioremap, which is best done with this back in crb_map_io  ??
> 
> Thanks for looking at this stuff,

I had almost forgotten this comment. I'll try this out as soon as
possible. Might well be the reason.

> Jason

/Jarkko