linux-kernel - Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with IS31FL32XX driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160305000059.519c3b14.drivshin.allworx@gmail.com>
Date:	Sat, 5 Mar 2016 00:00:59 -0500
From:	"David Rivshin (Allworx)" <drivshin.allworx@...il.com>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 4/4] leds: Replace dedicated SN3218 driver with
 IS31FL32XX driver

On Fri, 4 Mar 2016 22:14:27 +0100 (CET)
Stefan Wahren <stefan.wahren@...e.com> wrote:

> Hi David,
> 
> > "David Rivshin (Allworx)" <drivshin.allworx@...il.com> hat am 3. März 2016 um
> > 04:01 geschrieben:
> >
> >
> > From: David Rivshin <drivshin@...worx.com>
> >
> > Si-En Technology was acquired by ISSI in 2011, and it appears that
> > the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices.
> > As the IS31FL32XX driver already handles the *3218 devices, there
> > is no longer a need for the dedicated SN3218 driver.
> >
> > Add the "sn,sn3218" and "sn,sn3216" compatible strings into the
> > IS31FL32XX driver and binding documentation, and remove the
> > leds-sn3218 driver.
> >
> > Datasheets:
> > IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf
> > SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf
> >
> > IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf
> > SN3216; http://www.si-en.com/uploadpdf/SN3216201152410148.pdf
> >
> > Signed-off-by: David Rivshin <drivshin@...worx.com>  
> 
> i tested this patch successfully with a Raspberry Pi and a PiGlow (SN3218).
> 
> Tested-by: Stefan Wahren <stefan.wahren@...e.com>

Thanks very much for testing!

The PiGlow looks interesting, if I had known about it I might have just
ordered one for testing myself. Looks rather easier to hook up than the 
ISSI 3216 eval board.