linux-kernel - Re: [PATCH] nbd: use correct div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56DA262C.5050001@fb.com>
Date:	Fri, 4 Mar 2016 17:19:56 -0700
From:	Jens Axboe <axboe@...com>
To:	Arnd Bergmann <arnd@...db.de>, Markus Pargmann <mpa@...gutronix.de>
CC:	<nbd-general@...ts.sourceforge.net>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nbd: use correct div_s64 helper

On 03/04/2016 04:49 PM, Arnd Bergmann wrote:
> The do_div() macro now checks its arguments for the correct type,
> and refuses anything other than u64, so we get a warning about
> nbd_ioctl passing in an loff_t:
>
> drivers/block/nbd.c: In function '__nbd_ioctl':
> drivers/block/nbd.c:757:77: error: comparison of distinct pointer types lacks a cast [-Werror]
>
> This changes the nbd code to use div_s64() instead, which takes
> a signed argument.

Thanks Arnd, applied.

-- 
Jens Axboe