linux-kernel - Re: [PATCH v2] serial: core: remove baud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56DAB33F.50802@gmail.com>
Date:	Sat, 5 Mar 2016 18:21:51 +0800
From:	Caesar Wang <caesar.upstream@...il.com>
To:	Jeffy Chen <jeffy.chen@...k-chips.com>, gregkh@...uxfoundation.org
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	jslaby@...e.com, linux-rockchip@...ts.infradead.org,
	Doug Anderson <dianders@...omium.org>,
	Caesar Wang <wxt@...k-chips.com>,
	Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v2] serial: core: remove baud_rates when serial console
 setup

Hi,

I don't see this patch in mainline.:-(
Sorry for noise if this patch has applied by Greg.

在 2016年01月04日 15:54, Jeffy Chen 写道:
> Currently, when tring to set up a serial console with a higher
> baud rate, it would fallback to 921600.
>
> Tested-by: Jianqun Xu <jay.xu@...k-chips.com>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

Verified on RK3228/RK3229 SoCs.
Tested-by: Caesar Wang <wxt@...k-chips.com>


>
> ---
>
> Changes in v2:
> remove baud_rates as Alan's suggestion.
>
>   drivers/tty/serial/serial_core.c | 33 ++-------------------------------
>   1 file changed, 2 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index def5199..150547c 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1892,26 +1892,6 @@ uart_parse_options(char *options, int *baud, int *parity, int *bits, int *flow)
>   }
>   EXPORT_SYMBOL_GPL(uart_parse_options);
>   
> -struct baud_rates {
> -	unsigned int rate;
> -	unsigned int cflag;
> -};
> -
> -static const struct baud_rates baud_rates[] = {
> -	{ 921600, B921600 },
> -	{ 460800, B460800 },
> -	{ 230400, B230400 },
> -	{ 115200, B115200 },
> -	{  57600, B57600  },
> -	{  38400, B38400  },
> -	{  19200, B19200  },
> -	{   9600, B9600   },
> -	{   4800, B4800   },
> -	{   2400, B2400   },
> -	{   1200, B1200   },
> -	{      0, B38400  }
> -};
> -
>   /**
>    *	uart_set_options - setup the serial console parameters
>    *	@port: pointer to the serial ports uart_port structure
> @@ -1927,7 +1907,6 @@ uart_set_options(struct uart_port *port, struct console *co,
>   {
>   	struct ktermios termios;
>   	static struct ktermios dummy;
> -	int i;
>   
>   	/*
>   	 * Ensure that the serial console lock is initialised
> @@ -1942,16 +1921,8 @@ uart_set_options(struct uart_port *port, struct console *co,
>   
>   	memset(&termios, 0, sizeof(struct ktermios));
>   
> -	termios.c_cflag = CREAD | HUPCL | CLOCAL;
> -
> -	/*
> -	 * Construct a cflag setting.
> -	 */
> -	for (i = 0; baud_rates[i].rate; i++)
> -		if (baud_rates[i].rate <= baud)
> -			break;
> -
> -	termios.c_cflag |= baud_rates[i].cflag;
> +	termios.c_cflag |= CREAD | HUPCL | CLOCAL;
> +	tty_termios_encode_baud_rate(&termios, baud, baud);
>   
>   	if (bits == 7)
>   		termios.c_cflag |= CS7;