linux-kernel - Re: [PATCH V4 6/6] slim: qcom: Add runtime-pm support using clock-pause feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160305052900.GF18327@sirena.org.uk>
Date:	Sat, 5 Mar 2016 14:29:00 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Sagar Dharia <sdharia@...eaurora.org>
Cc:	gregkh@...uxfoundation.org, bp@...e.de, poeschel@...onage.de,
	treding@...dia.com, gong.chen@...ux.intel.com,
	andreas.noever@...il.com, alan@...ux.intel.com,
	mathieu.poirier@...aro.org, daniel@...ll.ch, oded.gabbay@....com,
	jkosina@...e.cz, sharon.dvir1@...l.huji.ac.il, joe@...ches.com,
	davem@...emloft.net, james.hogan@...tec.com,
	michael.opdenacker@...e-electrons.com, daniel.thompson@...aro.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kheitke@...ience.com, mlocke@...eaurora.org, agross@...eaurora.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V4 6/6] slim: qcom: Add runtime-pm support using
 clock-pause feature

On Sat, Feb 06, 2016 at 11:44:25AM -0700, Sagar Dharia wrote:

> @@ -253,6 +276,7 @@ static int msm_xfer_msg(struct slim_controller *ctrl, struct slim_msg_txn *txn,
>  	if (txn->msg && txn->msg->wbuf)
>  		memcpy(puc, txn->msg->wbuf, txn->msg->num_bytes);
>  
> +
>  	return msm_slim_queue_tx(dev, head, txn->rl, MGR_TX_MSG);
>  }
>  

This change for some reason seems to have a few of these random
whitespace only changes here.

> +	ret = slim_ctrl_clk_pause(&dev->ctrl, false, SLIM_CLK_UNSPECIFIED);
> +	if (ret)
> +		dev_err(device, "clk pause not entered:%d", ret);
> +	else {
> +		clk_disable_unprepare(dev->hclk);
> +		clk_disable_unprepare(dev->rclk);
> +	}
> +	return ret;

Coding style, {} should be on both sides.  It's also a bit odd that we
don't ever reenable these clocks.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)