lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 05 Mar 2016 01:34:43 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Joe Perches <joe@...ches.com>
Cc:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Varun Prakash <varun@...lsio.com>, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxgbit: fix dma_addr_t printk format

On Friday 04 March 2016 16:25:07 Joe Perches wrote:
> > 
> > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> > index 07e2bc86d0df..d667bc88e21d 100644
> > --- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> > +++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c
> > @@ -179,7 +179,7 @@ cxgbit_dump_sgl(const char *cap, struct scatterlist *sgl, int nents)
> >       for_each_sg(sgl, sg, nents, i)
> >               pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma 0x%llx, %u\n",
> >                       i, nents, sg, sg->length, sg->offset, sg_page(sg),
> > -                     sg_dma_address(sg), sg_dma_len(sg));
> > +                     (u64)sg_dma_address(sg), sg_dma_len(sg));
> >  }
> >  
> >  static int cxgbit_ddp_sgl_check(struct scatterlist *sgl, int nents)
> 
> You could create a temporary:
> 
>         for_each_sg(sgl, sg, nents, i) {
>                 dma_addr_t addr = sg_dma_address(sg);
> 
>                 pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma %pad, %u\n",
>                         i, nents, sg, sg->length, sg->offset, sg_page(sg),
>                         &addr, sg_dma_len(sg));
>         }
> 

Sure, but the cast seemed nicer in this case, the result is the same.
	
	Arnd

Powered by blists - more mailing lists