linux-kernel - Re: [PATCH] mailbox: sti: fix check of error code returned by devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160306030100.GA3326@x1>
Date:	Sun, 6 Mar 2016 10:01:00 +0700
From:	Lee Jones <lee.jones@...aro.org>
To:	Vladimir Zapolskiy <vz@...ia.com>
Cc:	Jassi Brar <jassisinghbrar@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: sti: fix check of error code returned by
 devm_ioremap_resource()

On Sun, 06 Mar 2016, Vladimir Zapolskiy wrote:

> The change fixes potential oops while accessing iomem on invalid
> address, if devm_ioremap_resource() fails due to some reason.
> 
> The devm_ioremap_resource() function returns ERR_PTR() and never
> returns NULL, which makes useless a following check for NULL.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
> Fixes: 9ef4546cbd7e ("mailbox: Add support for ST's Mailbox IP")
> ---
>  drivers/mailbox/mailbox-sti.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
> index 2394cfe..a334db5 100644
> --- a/drivers/mailbox/mailbox-sti.c
> +++ b/drivers/mailbox/mailbox-sti.c
> @@ -430,8 +430,8 @@ static int sti_mbox_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	mdev->base = devm_ioremap_resource(&pdev->dev, res);
> -	if (!mdev->base)
> -		return -ENOMEM;
> +	if (IS_ERR(mdev->base))
> +		return PTR_ERR(mdev->base);
>  
>  	ret = of_property_read_string(np, "mbox-name", &mdev->name);
>  	if (ret)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog