linux-kernel - Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160307083224.GB31189@ulmo.nvidia.com>
Date:	Mon, 7 Mar 2016 09:32:24 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Matt Longnecker <mlongnecker@...dia.com>
Cc:	Wei Ni <wni@...dia.com>, rui.zhang@...el.com,
	mikko.perttunen@...si.fi, swarren@...dotorg.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote:
> 
> 
> On 03/01/2016 11:40 PM, Wei Ni wrote:
> >>diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> >>index 74ea5765938b..136975220c92 100644
> >>--- a/drivers/thermal/tegra_soctherm.c
> >>+++ b/drivers/thermal/tegra_soctherm.c
> >>@@ -57,7 +57,7 @@
> >>  #define READBACK_VALUE_MASK			0xff00
> >>  #define READBACK_VALUE_SHIFT			8
> >>  #define READBACK_ADD_HALF			BIT(7)
> >>-#define READBACK_NEGATE				BIT(1)
> >>+#define READBACK_NEGATE				BIT(0)
> I confirm that this change is technically correct. It fixes a bug.

That usually translates to a Reviewed-by: tag. =)

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)