linux-kernel - Re: [PATCH] iio: adc: imx25-gcq: fix do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8010548.jDMIC4yOG6@adelgunde>
Date:	Mon, 07 Mar 2016 10:01:34 +0100
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	linux-kernel@...r.kernel.org, kernel-testers@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div

Hi,

On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
> On 03/03/16 12:51, Sudip Mukherjee wrote:
> > We are getting build failure with tilepro allmodconfig with the error:
> > 
> > drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
> > do_div(priv->channel_vref_mv[reg], 1000);
> >     ^
> > 
> > include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
> > 	{aka long long unsigned int *}' but argument is of type 'u32 *
> > 	{aka unsigned int *}'
> > 
> > Create a temporary variable of type u64 and use that in do_div.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> Markus, can you take a quick look at this. 

Thanks. I think this was already fixed by Arnd.
	"iio: adc/imx25-gcq: move incorrect do_div"

Best Regards,

Markus

> 
> > ---
> > 
> > tilepro allmodconfig build log is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/113325889
> > 
> >  drivers/iio/adc/fsl-imx25-gcq.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> > index 2fd1927..e0636d4 100644
> > --- a/drivers/iio/adc/fsl-imx25-gcq.c
> > +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> > @@ -174,6 +174,7 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
> >  	struct device *dev = &pdev->dev;
> >  	unsigned int refp_used[4] = {};
> >  	int ret, i;
> > +	u64 temp;
> >  
> >  	/*
> >  	 * Setup all configurations registers with a default conversion
> > @@ -233,7 +234,9 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
> >  			priv->channel_vref_mv[reg] =
> >  				regulator_get_voltage(priv->vref[refp]);
> >  			/* Conversion from uV to mV */
> > -			do_div(priv->channel_vref_mv[reg], 1000);
> > +			temp = priv->channel_vref_mv[reg];
> > +			do_div(temp, 1000);
> > +			priv->channel_vref_mv[reg] = temp;
> >  			break;
> >  		case MX25_ADC_REFP_INT:
> >  			priv->channel_vref_mv[reg] = 2500;
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)