lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160307102413.GB6356@twins.programming.kicks-ass.net>
Date:	Mon, 7 Mar 2016 11:24:13 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	Andi Kleen <ak@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"Liang, Kan" <kan.liang@...el.com>, Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 2/3] perf/x86/pebs: add workaround for broken OVFL status
 on HSW

On Thu, Mar 03, 2016 at 03:40:49PM -0800, Stephane Eranian wrote:
> On Thu, Mar 3, 2016 at 1:43 PM, Andi Kleen <ak@...ux.intel.com> wrote:
> >
> > > +             /*
> > > +              * There are cases where, even though, the PEBS ovfl bit is set in
> > > +              * GLOBAL_OVF_STATUS, the PEBS events may also have their overflow bits
> > > +              * set for their counters. We must clear them here because they have
> > > +              * been processed as exact samples in the drain_pebs() routine. They
> > > +              * must not be processed again in the for_each_bit_set() loop for
> > > +              * regular samples below.
> > > +              */
> > > +             status &= ~cpuc->pebs_enabled;
> > > +             status &= x86_pmu.intel_ctrl | GLOBAL_STATUS_TRACE_TOPAPMI;
> >
> > If you just clear the bits here they will not be acked and stay around
> > forever in GLOBAL_STATUS, which causes other problems.
> >
> > You need a separate ack_status variable that contains all bits and is always
> > acked.
> 
> I understand that. You mean I need to that has all the bits that were set to
> call intel_pmu_ack_status().
> 
> But if you look at the code, and where I made the change, there is no more
> intel_pmu_ack_status() BEFORE you read the status again via
> intel_pmu_get_status().
> 
> So why would I need to keep another variable around?

I suspect Andi is having something along:

 lkml.kernel.org/r/1445458568-16956-1-git-send-email-andi@...stfloor.org

applied to his tree.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ