linux-kernel - Re: [PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Mar 2016 12:27:36 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Rob Herring <robh@...nel.org>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd

Hi Rob,

On Fri, Mar 4, 2016 at 4:13 PM, Rob Herring <robh@...nel.org> wrote:
> Sync to upstream dtc commit 53bf130b1cdd ("libfdt: simplify
> fdt_node_check_compatible()"). This adds the following commits from
> upstream:
>
> 53bf130 libfdt: simplify fdt_node_check_compatible()
> c9d9121 Warn on node name unit-address presence/absence mismatch
> 2e53f9d Catch unsigned 32bit overflow when parsing flattened device tree offsets
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> As usual, this is just an automated copy of upstream dtc into the kernel
> tree. The changeset is small enough that I have left it here.
>
> The main reason for this sync is to pick-up the new unit-address
> warnings.

I gave this a try. Obviously it finds many abuses that should be fixed.

However, I'm wondering about the following, where the unit-address is just
used to distinguish between multiple instances:

    Warning (unit_address_vs_reg): Node /cache-controller@0 has a unit
name, but no reg property
        compatible = "cache";
    Warning (unit_address_vs_reg): Node /regulator@1 has a unit name,
but no reg property
        compatible = "regulator-fixed"
    Warning (unit_address_vs_reg): Node /i2c@2 has a unit name, but no
reg property
        compatible = "i2c-gpio"

How should these be fixed?

BTW, there seems to be a missing dependency of the DTBs on the dtc itself.
Applying your patch and running "make dtbs" didn't rebuilt any DTBs.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds