linux-kernel - RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <744357E9AAD1214791ACBA4B0B9092633A972237@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 7 Mar 2016 12:27:01 +0000
From:	"Zhang, Rui" <rui.zhang@...el.com>
To:	Wei Ni <wni@...dia.com>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"mikko.perttunen@...si.fi" <mikko.perttunen@...si.fi>,
	Eduardo Valentin <edubezval@...il.com>
CC:	Matt Longnecker <mlongnecker@...dia.com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

Oh, BTW, you need to CC linux-pm@...r.kernel.org as well, so that we can see your patch via patchwork.

Please resend patch V2 to linux-pm@...r.kernel.org.

Thanks,
rui

> -----Original Message-----
> From: Wei Ni [mailto:wni@...dia.com]
> Sent: Monday, March 07, 2016 5:16 PM
> To: Zhang, Rui <rui.zhang@...el.com>; thierry.reding@...il.com;
> mikko.perttunen@...si.fi; Eduardo Valentin <edubezval@...il.com>
> Cc: Matt Longnecker <mlongnecker@...dia.com>; swarren@...dotorg.org;
> linux-tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
> Importance: High
> 
> 
> 
> On 2016年03月07日 16:55, Zhang, Rui wrote:
> > For the soc thermal driver changes, you'd better cc Eduardo at the same
> time so that he can include this in his soc-thermal pull request.
> > Surely I can queue this for 4.6 if Eduardo miss this.
> 
> Thanks for your help.
> 
> BTW, please add:
> Reviewed-by: Matt Longnecker <mlongnecker@...dia.com>
> 
> Or I need to send v2 patch to add it?
> 
> Thanks.
> Wei.
> 
> >
> > Thanks,
> > rui
> >
> >> -----Original Message-----
> >> From: Wei Ni [mailto:wni@...dia.com]
> >> Sent: Monday, March 07, 2016 4:26 PM
> >> To: thierry.reding@...il.com; Zhang, Rui <rui.zhang@...el.com>;
> >> mikko.perttunen@...si.fi
> >> Cc: Matt Longnecker <mlongnecker@...dia.com>;
> swarren@...dotorg.org;
> >> linux-tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of
> >> temperature
> >> Importance: High
> >>
> >> Hi, Rui and Thierry
> >> Could you please take a look at this patch?
> >>
> >> Thanks.
> >> Wei.
> >>
> >> On 2016年03月03日 08:08, Matt Longnecker wrote:
> >>>
> >>>
> >>> On 03/01/2016 11:40 PM, Wei Ni wrote:
> >>>>> diff --git a/drivers/thermal/tegra_soctherm.c
> >> b/drivers/thermal/tegra_soctherm.c
> >>>>> index 74ea5765938b..136975220c92 100644
> >>>>> --- a/drivers/thermal/tegra_soctherm.c
> >>>>> +++ b/drivers/thermal/tegra_soctherm.c
> >>>>> @@ -57,7 +57,7 @@
> >>>>>  #define READBACK_VALUE_MASK            0xff00
> >>>>>  #define READBACK_VALUE_SHIFT            8
> >>>>>  #define READBACK_ADD_HALF            BIT(7)
> >>>>> -#define READBACK_NEGATE                BIT(1)
> >>>>> +#define READBACK_NEGATE                BIT(0)
> >>> I confirm that this change is technically correct. It fixes a bug.