linux-kernel - [PATCH] EDAC, sb_edac: Fixed logic error in sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com>
Date:	Mon,  7 Mar 2016 15:30:45 +0100
From:	Hubert Chrzaniuk <hubert.chrzaniuk@...el.com>
To:	hubert.chrzaniuk@...el.com, lukasz.anaczkowski@...el.com,
	mchehab@....samsung.com, dougthompson@...ssion.com, bp@...en8.de,
	linux-edac@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver

Patch corrects a typo introduced previously.
As a result under some configurations dimms were not
correctly recognized. Problem affects only Xeon Phi architecture.

Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@...el.com>
---
 drivers/edac/sb_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index e438ee5..f5c6b97 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -1574,7 +1574,7 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
 				for (cha = 0; cha < KNL_MAX_CHAS; cha++) {
 					if (knl_get_mc_route(target,
 						mc_route_reg[cha]) == channel
-						&& participants[channel]) {
+						&& !participants[channel]) {
 						participant_count++;
 						participants[channel] = 1;
 						break;
-- 
1.8.3.1