linux-kernel - Re: [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160307180800.GA21297@kernel.org>
Date:	Mon, 7 Mar 2016 15:08:00 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio

Em Mon, Mar 07, 2016 at 03:06:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Mar 07, 2016 at 11:35:06PM +0900, Namhyung Kim escreveu:
> > Now hpp formats are linked using perf_hpp_list_node when hierarchy is
> > enabled.  Use this info to print entries with multiple sort keys in a
> > single hierarchy properly.
> > 
> > For example, the below example shows using 4 sort keys with 2 levels.
> > 
> >   $ perf report --hierarchy -s '{prev_pid,prev_comm},{next_pid,next_comm}' \
> >    --percent-limit 1 -i perf.data.sched
> >   ...
> >   #    Overhead  prev_pid+prev_comm / next_pid+next_comm
> >   # ...........  .......................................
> >   #
> 
> Ok, this one addresses my previous comment, I think the next one will do it for
> the TUI, good. :-)
> 
> 
> -#    Overhead  prev_pid / prev_comm / next_pid / next_comm
> -# ...........  ...........................................
> +#    Overhead  prev_pid+prev_comm / next_pid+next_comm
> +# ...........  .......................................

It ends up adding an extra space to the other cases, harmless, I guess:

@@ -68,7 +68,7 @@
 # Samples: 1K of event 'sched:sched_stat_sleep'
 # Event count (approx.): 0
 #
-# Overhead
+# Overhead  
  ........
 #

Do you test like:

   perf report ... > /tmp/before
   make
   perf report ... > /tmp/after
   diff /tmp/before /tmp/after

?