linux-kernel - Re: [PATCH] udp6: fix UDP/IPv6 encap resubmit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307.152352.119878767057546985.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 15:23:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wsommerfeld@...gle.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, johunt@...mai.com, bcrl@...ck.org,
	edumazet@...gle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udp6: fix UDP/IPv6 encap resubmit path

From: Bill Sommerfeld <wsommerfeld@...gle.com>
Date: Fri,  4 Mar 2016 14:47:21 -0800

> IPv4 interprets a negative return value from a protocol handler as a
> request to redispatch to a new protocol.  In contrast, IPv6 interprets a
> negative value as an error, and interprets a positive value as a request
> for redispatch.
> 
> UDP for IPv6 was unaware of this difference.  Change __udp6_lib_rcv() to
> return a positive value for redispatch.  Note that the socket's
> encap_rcv hook still needs to return a negative value to request
> dispatch, and in the case of IPv6 packets, adjust IP6CB(skb)->nhoff to
> identify the byte containing the next protocol.
> 
> Signed-off-by: Bill Sommerfeld <wsommerfeld@...gle.com>

Applied and queued up for -stable, thanks.