linux-kernel - Re: [PATCH] arch/microblaze: export isa_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160307203215.GA26149@localhost>
Date:	Mon, 7 Mar 2016 14:32:15 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Nicolai Stange <nicstange@...il.com>
Cc:	Michal Simek <monstr@...str.eu>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Takashi Iwai <tiwai@...e.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Yijing Wang <wangyijing@...wei.com>,
	Yinghai Lu <yinghai@...nel.org>,
	kbuild test robot <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/microblaze: export isa_io_base to modules

On Mon, Mar 07, 2016 at 08:29:24PM +0100, Nicolai Stange wrote:
> As discovered by the kbuild test robot, an allmodconfig build on
> microblaze bails out with
> 
>   ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
>   ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined!
>   [... plus dozens more throughout the tree]
> 
> Export isa_io_base to modules by means of EXPORT_SYMBOL().
> 
> Signed-off-by: Nicolai Stange <nicstange@...il.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Michal, this was sent to you, so I assume you'll handle it.  Let me
know if you want me to do anything else with it.

> ---
>  arch/microblaze/pci/pci-common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
> index ae838ed..fba7a46 100644
> --- a/arch/microblaze/pci/pci-common.c
> +++ b/arch/microblaze/pci/pci-common.c
> @@ -48,6 +48,8 @@ static int global_phb_number;		/* Global phb counter */
>  resource_size_t isa_mem_base;
>  
>  unsigned long isa_io_base;
> +EXPORT_SYMBOL(isa_io_base);
> +
>  static int pci_bus_count;
>  
>  struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
> -- 
> 2.7.2
>