linux-kernel - Re: [PATCH net-next] hv_netvsc: Move subchannel waiting to rndis_filter_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307.153809.1538719544106524749.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 15:38:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	haiyangz@...rosoft.com
Cc:	netdev@...r.kernel.org, kys@...rosoft.com, olaf@...fle.de,
	vkuznets@...hat.com, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH net-next] hv_netvsc: Move subchannel waiting to
 rndis_filter_device_remove()

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Fri,  4 Mar 2016 15:07:43 -0800

> During hot add, vmbus_device_register() is called from vmbus_onoffer(), on
> the same workqueue as the subchannel offer message work-queue, so 
> subchannel offer won't be processed until the vmbus_device_register()/...
> /netvsc_probe() is done.
> Also, vmbus_device_register() is called with channel_mutex locked, which
> prevents subchannel processing too. So the "waiting for sub-channel 
> processing" will not success in hot add case. But, in usual module loading,
> the netvsc_probe() is called from different code path, and doesn't fail.
> 
> This patch resolves the deadlock during NIC hot-add, and speeds up NIC 
> loading time.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>

Applied, thanks.