linux-kernel - Re: [PATCH 1/1] staging: android: Fixed coding style issues reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Mar 2016 17:21:08 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Saiyam Doshi <saiyamdoshi.in@...il.com>
Cc:	arve@...roid.com, riandrews@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Fixed coding style issues reported
 by checkpatch

On Mon, Mar 07, 2016 at 01:00:33AM +0530, Saiyam Doshi wrote:
> List of modified files with comment,
> lowmemorykiller.c: Added blank line after array declaration
> sync.h: Added comment for spinlock_t definition,
>         Fixed parentheses alignment in function declaration
> sync_debug.c: Removed unnecessary braces for single statement block
> timed_gpio.c: Added comment for spinlock_t definition

You need to do only one thing per patch, please split this up into
multiple patches.

Also verify that these are all really needed, please always work against
linux-next, not Linus's kernel tree.

thanks,

greg k-h