linux-kernel - Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160307230442.GU6344@twins.programming.kicks-ass.net>
Date:	Tue, 8 Mar 2016 00:04:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vikas Shivappa <vikas.shivappa@...ux.intel.com>
Cc:	vikas.shivappa@...el.com, linux-kernel@...r.kernel.org,
	x86@...nel.org, hpa@...or.com, tglx@...utronix.de,
	mingo@...nel.org, ravi.v.shankar@...el.com, tony.luck@...el.com,
	fenghua.yu@...el.com, h.peter.anvin@...el.com
Subject: Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events
 into a cache_group

On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote:
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -121,6 +121,7 @@ struct hw_perf_event {
>  		struct { /* intel_cqm */
>  			int			cqm_state;
>  			u32			cqm_rmid;
> +			bool			is_group_event;
>  			struct list_head	cqm_events_entry;
>  			struct list_head	cqm_groups_entry;
>  			struct list_head	cqm_group_entry;

Please, no 'bool' in structures.