linux-kernel - [PATCH] sctp: fix noderef.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 07:17:55 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, dvyukov@...gle.com,
	nhorman@...driver.com, vyasevich@...il.com,
	linux-sctp@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzkaller@...glegroups.com, kcc@...gle.com, glider@...gle.com,
	sasha.levin@...cle.com, edumazet@...gle.com, davem@...emloft.net
Subject: [PATCH] sctp: fix noderef.cocci warnings

net/sctp/bind_addr.c:458:42-48: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

CC: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 bind_addr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sctp/bind_addr.c
+++ b/net/sctp/bind_addr.c
@@ -455,7 +455,7 @@ static int sctp_copy_one_addr(struct net
 		    (((AF_INET6 == addr->sa.sa_family) &&
 		      (flags & SCTP_ADDR6_ALLOWED) &&
 		      (flags & SCTP_ADDR6_PEERSUPP))))
-			error = sctp_add_bind_addr(dest, addr, sizeof(addr),
+			error = sctp_add_bind_addr(dest, addr, sizeof(*addr),
 						   SCTP_ADDR_SRC, gfp);
 	}