linux-kernel - Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1457401187-sup-7130@delenn.ozlabs.ibm.com>
Date:	Tue, 08 Mar 2016 12:42:38 +1100
From:	Ian Munsie <imunsie@....ibm.com>
To:	Matt Ochs <mrochs@...ibm.com>
Cc:	linuxppc-dev <linuxppc-dev@...abs.org>,
	Michael Neuling <mikey@...ling.org>,
	Manoj Kumar <kumarmn@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Michael Ellerman <michaele@....ibm.com>
Subject: Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

Excerpts from Matt Ochs's message of 2016-03-08 11:26:55 +1100:
> Any reason for adding these extra lines as part of this commit?

mpe asked for some newlines here in the v1 submission, and it only
really made sense to do so if all the related sections had consistent
whitespace as well.

> > +/*
> > + * AFU driver ops allows an AFU driver to create their own events to pass to
> > + * userspace through the file descriptor as a simpler alternative to overriding
> > + * the read() and poll() calls that works with the generic cxl events. These
> > + * events are given priority over the generic cxl events, so will be delivered
> 
> so _they_ will be delivered

thanks for spotting that...

> > + *
> > + * even_pending() will be called by the cxl driver to check if an event is
> > + * pending (e.g. in select/poll/read calls).
> 
> event_pending() <- missing 't'

...and that.

Cheers,
-Ian