linux-kernel - RE: [PATCH] mfd: act8945a: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 01:53:37 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	kbuild test robot <lkp@...el.com>
CC:	"kbuild-all@...org" <kbuild-all@...org>,
	Lee Jones <lee.jones@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

Hi Fengguang Wu,

Thank you for your patch.

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@...el.com]
> Sent: 2016年3月8日 7:54
> To: Yang, Wenyou <Wenyou.Yang@...el.com>
> Cc: kbuild-all@...org; Lee Jones <lee.jones@...aro.org>; Rob Herring
> <robh+dt@...nel.org>; Pawel Moll <pawel.moll@....com>; Mark Rutland
> <mark.rutland@....com>; Ian Campbell <ijc+devicetree@...lion.org.uk>; Kumar
> Gala <galak@...eaurora.org>; Ferre, Nicolas <Nicolas.FERRE@...el.com>;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; Yang, Wenyou
> <Wenyou.Yang@...el.com>
> Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> 
> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Wenyou Yang <wenyou.yang@...el.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Reviewed-by: Wenyou Yang <wenyou.yang@...el.com>

> ---
> 
>  act8945a.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/mfd/act8945a.c
> +++ b/drivers/mfd/act8945a.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc  static
> struct i2c_driver act8945a_i2c_driver = {
>  	.driver = {
>  		   .name = "act8945a",
> -		   .owner = THIS_MODULE,
>  		   .of_match_table = of_match_ptr(act8945a_of_match),
>  	},
>  	.probe = act8945a_i2c_probe,


Best Regards,
Wenyou Yang