linux-kernel - Re: [PATCH v6 0/4] powercap/rapl: reduce ipi calls and misc clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 08:57:54 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux PM <linux-pm@...r.kernel.org>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH v6 0/4] powercap/rapl: reduce ipi calls and misc clean
 up

On Mon, 7 Mar 2016, Jacob Pan wrote:

> On Wed, 24 Feb 2016 13:31:34 -0800
> Jacob Pan <jacob.jun.pan@...ux.intel.com> wrote:
> 
> > Changes since v5:
> > 	- Split changes into seprate patches. No code change.
> > Changes since V4:
> > 	- Deleted unnecessary cpumask_any_and() call, assign first
> > cpu as lead Changes since V3:
> > 	- Avoid for_each_online_cpu() search for per package MSR
> > access. This is achieved by tracking a per package lead cpu via
> > cpumask_xx() calls. (suggested by Thomas Gleixner
> > <tglx@...utronix.de>)
> > 	    - Add direct reference of RAPL package for each RAPL
> > domain.
> > 
> > Jacob Pan (4):
> >   cpumask: export cpumask_any_but
> >   powercap/rapl: reduce ipi calls
> >   powercap/rapl: add package reference per domain
> >   powercap/rapl: track lead cpu per package
> > 
> >  drivers/powercap/intel_rapl.c | 220
> > ++++++++++++++++++++++--------------------
> > lib/cpumask.c                 |   1 + 2 files changed, 115
> > insertions(+), 106 deletions(-)
> > 
> Hi Thomas,
> 
> Do you have more comments?

No. Looks reasonable now.