linux-kernel - Re: [PATCH v2 0/9] cleanup around kvm_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56DE869B.9030908@lab.ntt.co.jp>
Date:	Tue, 8 Mar 2016 17:00:27 +0900
From:	Takuya Yoshikawa <yoshikawa_takuya_b1@....ntt.co.jp>
To:	Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org
Cc:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Subject: Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few
 micro-optimizations

On 2016/03/07 23:15, Paolo Bonzini wrote:
> Having committed the ubsan fixes, this are the cleanups that are left.
> 
> Compared to v1, I have fixed the patch to coalesce page zapping after
> mmu_sync_children (as requested by Takuya and Guangrong), and I have
> rewritten is_last_gpte again in an even simpler way.
> 
> Paolo
> 
> Paolo Bonzini (9):
>    KVM: MMU: introduce kvm_mmu_flush_or_zap
>    KVM: MMU: move TLB flush out of __kvm_sync_page
>    KVM: MMU: use kvm_sync_page in kvm_sync_pages
>    KVM: MMU: cleanup __kvm_sync_page and its callers
>    KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page*
>    KVM: MMU: move zap/flush to kvm_mmu_get_page
>    KVM: MMU: coalesce more page zapping in mmu_sync_children

1-7 look good to me.

>    KVM: MMU: simplify is_last_gpte
>    KVM: MMU: micro-optimize gpte_access

8 and 9 look reasonable to me, though I read them only briefly.

  Takuya