linux-kernel - [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457428095-2801-1-git-send-email-sushaanth.s@ti.com>
Date:	Tue, 8 Mar 2016 14:38:15 +0530
From:	Sushaanth Srirangapathi <sushaanth.s@...com>
To:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>
CC:	Sekhar Nori <nsekhar@...com>, <linux-omap@...r.kernel.org>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	Sushaanth Srirangapathi <sushaanth.s@...com>
Subject: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand

Commit 28c015a9daabe4e ("mtd: davinci-nand: disable subpage write for
keystone-nand") disables subpage write for Keystone SOCs due to hw
issues.

But subpage writes doesn't work even for DaVinci SOCs due to hw issues.
So set NAND_NO_SUBPAGE_WRITE option for all devices compatible to
this driver.

I tested this patch using DA850 board.

Signed-off-by: Sushaanth Srirangapathi <sushaanth.s@...com>
---
 drivers/mtd/nand/davinci_nand.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 8cb821b..466439c 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -601,11 +601,7 @@ static struct davinci_nand_pdata
 		    of_property_read_bool(pdev->dev.of_node,
 			"ti,davinci-nand-use-bbt"))
 			pdata->bbt_options = NAND_BBT_USE_FLASH;
-
-		if (of_device_is_compatible(pdev->dev.of_node,
-					    "ti,keystone-nand")) {
-			pdata->options |= NAND_NO_SUBPAGE_WRITE;
-		}
+		pdata->options |= NAND_NO_SUBPAGE_WRITE;
 	}
 
 	return dev_get_platdata(&pdev->dev);
-- 
1.7.9.5