linux-kernel - Re: [PATCH] Kernel: Power: main.c: Cleaned up a comment block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 10:44:53 +0100
From:	Pavel Machek <pavel@....cz>
To:	Philippe Loctaux <phil@...lippeloctaux.com>
Cc:	rjw@...ysocki.net, len.brown@...el.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Kernel: Power: main.c: Cleaned up a comment block

On Mon 2016-03-07 11:09:15, Philippe Loctaux wrote:
> Removed a * in the beginning of the block, and removed an unnecessary space.
> 
> Signed-off-by: Philippe Loctaux <phil@...lippeloctaux.com>

NAK.

Google kerneldoc, people actually like two spaces after ., and you
should not be changing whitespace unless you update code, anyway.
								Pavel

> ---
>  kernel/power/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 2794697..d7386cb 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -288,11 +288,11 @@ static inline void pm_print_times_init(void) {}
>  
>  struct kobject *power_kobj;
>  
> -/**
> +/*
>   * state - control system sleep states.
>   *
>   * show() returns available sleep state labels, which may be "mem", "standby",
> - * "freeze" and "disk" (hibernation).  See Documentation/power/states.txt for a
> + * "freeze" and "disk" (hibernation). See Documentation/power/states.txt for a
>   * description of what they mean.
>   *
>   * store() accepts one of those strings, translates it into the proper

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html