lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Mar 2016 14:27:57 +0200 From: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com> To: Laxman Dewangan <ldewangan@...dia.com>, <linus.walleij@...aro.org>, <robh+dt@...nel.org> CC: <pawel.moll@....com>, <mark.rutland@....com>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>, <treding@...dia.com>, <swarren@...dotorg.org> Subject: Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed On 08.03.2016 14:02, Laxman Dewangan wrote: > Print the error number of GPIO hog failed during > its configurations. This helps in identifying the > failure without instrumenting the code. > > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com> > --- > drivers/gpio/gpiolib.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index bc788b9..7575ebb 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2621,15 +2621,16 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, > > local_desc = gpiochip_request_own_desc(chip, hwnum, name); > if (IS_ERR(local_desc)) { > - pr_err("requesting hog GPIO %s (chip %s, offset %d) failed\n", > - name, chip->label, hwnum); > + status = PTR_ERR(local_desc); > + pr_err("requesting hog GPIO %s, chip %s, offset %d failed %d\n", > + name, chip->label, hwnum, status); > return PTR_ERR(local_desc); You can do "return status;" now. > } > > status = gpiod_configure_flags(desc, name, dflags); > if (status < 0) { > - pr_err("setup of hog GPIO %s (chip %s, offset %d) failed\n", > - name, chip->label, hwnum); > + pr_err("setup of hog GPIO %s chip %s, offset %d failed %d\n", > + name, chip->label, hwnum, status); > gpiochip_free_own_desc(desc); > return status; > } > -- With best wishes, Vladimir
Powered by blists - more mailing lists