linux-kernel - Re: [PATCH 1/2] tracing: make tracer_flags use the right set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <618614723.26788676.1457450527276.JavaMail.zimbra@redhat.com>
Date:	Tue, 8 Mar 2016 10:22:07 -0500 (EST)
From:	Chunyu Hu <chuhu@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	liwan@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag
 callback



----- Original Message -----
> From: "Steven Rostedt" <rostedt@...dmis.org>
> To: "Chunyu Hu" <chuhu@...hat.com>
> Cc: liwan@...hat.com, linux-kernel@...r.kernel.org
> Sent: Tuesday, March 8, 2016 10:33:17 PM
> Subject: Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback
> 
> On Tue,  8 Mar 2016 21:37:01 +0800
> Chunyu Hu <chuhu@...hat.com> wrote:
> 
> > @@ -6373,7 +6384,6 @@ create_trace_option_files(struct trace_array *tr,
> > struct tracer *tracer)
> >  	struct tracer_flags *flags;
> >  	struct tracer_opt *opts;
> >  	int cnt;
> > -	int i;
> 
> I'm guessing this was a mistake.

Thanks for the quick review! This is an mistake, the change below should be after it. From my
limited knowledge and observation, seems there is no tracer sharing the tracer_flag except the
dummy_tracer flag. As in the patch that flag is not shared any more, so i also removed these check
in the previous email.


@@ -6390,15 +6400,6 @@ create_trace_option_files(struct trace_array *tr, struct tracer *tracer)
        if (!trace_ok_for_array(tracer, tr))
                return;
 
-       for (i = 0; i < tr->nr_topts; i++) {
-               /*
-                * Check if these flags have already been added.
-                * Some tracers share flags.
-                */
-               if (tr->topts[i].tracer->flags == tracer->flags)
-                       return;
-       }
-


> -- Steve
> 
> >  
> >  	if (!tracer)
> >  		return;
> 

-- 
Regards,
Chunyu Hu