linux-kernel - Re: [PATCH v1 0/3] PCI: Avoid touching non-compliant BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 11:50:20 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Andi Kleen <ak@...ux.intel.com>,
	Jayachandran Chandrashekaran Nair 
	<jayachandran.chandrashekaran@...adcom.com>,
	Rob Herring <robh@...nel.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v1 0/3] PCI: Avoid touching non-compliant BARs

On Fri, Feb 26, 2016 at 09:58:42AM -0600, Bjorn Helgaas wrote:
> Hi guys,
> 
> Here's a proposal for dealing with these devices that have non-BAR
> registers where BARs are supposed to be.  The idea is to:
> 
>   - have an early quirk mark these devices,
>   - disable IO & MEM decoding so the devices don't consume address space
>     we don't know about, and
>   - skip BAR sizing (so the struct resources stay zeroed out)
> 
> This is basically a modification of what Andi originally proposed.  The
> difference here is that we never touch the BAR at all, and we don't have to
> add any struct resource flags, so we don't have to worry about changing any
> consumers of the struct resources.
> 
> Let me know what you think.
> 
> ---
> 
> Bjorn Helgaas (3):
>       PCI: Disable IO/MEM decoding for devices with non-compliant BARs
>       x86/PCI: Mark Broadwell-EP Home Agent & PCU as having non-compliant BARs
>       PCI: Mark Broadcom Vulcan bridges as having non-compliant BARs
> 
> 
>  arch/x86/pci/fixup.c |    7 +++++++
>  drivers/pci/probe.c  |   14 ++++++++++++++
>  drivers/pci/quirks.c |   14 ++++++++++++++
>  include/linux/pci.h  |    1 +
>  4 files changed, 36 insertions(+)

I applied the first two patches, with Andi's Tested-by, to
pci/resource for v4.6.

Per Jayachandran, the Broadcom patch turned out not to be necessary,
so I dropped that one.

Bjorn