linux-kernel - Re: [PATCH v3 3/7] QE: Add uqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1457482393.5360.115.camel@buserror.net>
Date:	Tue, 08 Mar 2016 18:13:13 -0600
From:	Scott Wood <oss@...error.net>
To:	Qiang Zhao <qiang.zhao@....com>, Rob Herring <robh@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Xiaobo Xie <xiaobo.xie@....com>,
	Yang-Leo Li <leoyang.li@....com>
Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

On Tue, 2016-03-08 at 01:16 +0000, Qiang Zhao wrote:
> On Tue, Mar 08, 2016 at 1:28AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@...error.net]
> > Sent: Tuesday, March 08, 2016 1:28 AM
> > To: Qiang Zhao <qiang.zhao@....com>; Rob Herring <robh@...nel.org>
> > Cc: Yang-Leo Li <leoyang.li@....com>; Xiaobo Xie <xiaobo.xie@....com>;
> > linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; linuxppc-
> > dev@...ts.ozlabs.org
> > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > 
> > On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> > > On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > > > -----Original Message-----
> > > > From: Rob Herring [mailto:robh@...nel.org]
> > > > Sent: Saturday, March 05, 2016 12:26 PM
> > > > To: Qiang Zhao <qiang.zhao@....com>
> > > > Cc: oss@...error.net; Yang-Leo Li <leoyang.li@....com>; Xiaobo Xie
> > > > <xiaobo.xie@....com>; linux-kernel@...r.kernel.org;
> > > > devicetree@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org
> > > > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > > > 
> > > > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > > > Add uqe_serial document to
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > > 
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> > > > > ---
> > > > > Changes for v2
> > > > > 	- modify tx/rx-clock-name specification Changes for v2
> > > > > 	- NA
> > > > > 
> > > > >  .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19
> > > > +++++++++++++++++++
> > > > >  1 file changed, 19 insertions(+)
> > > > >  create mode 100644
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > new file mode 100644
> > > > > index 0000000..436c71c
> > > > > --- /dev/null
> > > > > +++
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > +++ txt
> > > > > @@ -0,0 +1,19 @@
> > > > > +* Serial
> > > > > +
> > > > > +Currently defined compatibles:
> > > > > +- ucc_uart
> > > > 
> > > > I guess this is in use already and okay. However, looking at the
> > > > driver there really should be SoC specific compatible strings here
> > > > since the driver is looking up the SoC compatible string and
> > > > composing the firmware filename from that.
> > > 
> > > Ok, I will changed both driver and this compatible.
> > 
> > But don't break existing device trees while doing so.
> 
> Do I need to send driver patch in this patchset or a individual patch?

Doesn't matter.

-Scott