linux-kernel - Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457564698.4525.33.camel@intel.com>
Date:	Wed, 9 Mar 2016 23:05:03 +0000
From:	"Verma, Vishal L" <vishal.l.verma@...el.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support

On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> ACPI 6.1 introduces the ability to send "clear error" commands to the
> ACPI0012:00 device representing the root of an "nvdimm bus".
> 
> Similar to relocating a bad block on a disk, this support clears
> media errors in response to a write.
> 
> ---
> 
> Dan Williams (3):
>       nfit, libnvdimm: clear poison command support
>       libnvdimm, pmem: fix kmap_atomic() leak in error path
>       libnvdimm, pmem: clear poison on write
> 
> 
>  arch/x86/include/asm/pmem.h      |    5 +++
>  drivers/acpi/nfit.c              |   12 ++++++-
>  drivers/nvdimm/bus.c             |   65
> ++++++++++++++++++++++++++++++++++++++
>  drivers/nvdimm/nd.h              |    2 +
>  drivers/nvdimm/pmem.c            |   40 ++++++++++++++++++++---
>  include/linux/pmem.h             |   19 +++++++++++
>  include/uapi/linux/ndctl.h       |   13 ++++++++
>  tools/testing/nvdimm/test/nfit.c |   29 +++++++++++++++++
>  8 files changed, 179 insertions(+), 6 deletions(-)

Except for the one comment in patch 1, this looks good to me!

For the series,
Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>