linux-kernel - Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is used alone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARcnsgqzsRFStUiWsFQZG8GiJRbxARDbtd51+RaVs97pQ@mail.gmail.com>
Date:	Wed, 9 Mar 2016 13:32:12 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Rob Herring <robh+dt@...nel.org>
Cc:	"arm@...nel.org" <arm@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Heiko Stuebner <heiko@...ech.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <andy.gross@...aro.org>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	David Brown <david.brown@...aro.org>,
	Pawel Moll <pawel.moll@....com>, Wei Xu <xuwei5@...ilicon.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Mark Rutland <mark.rutland@....com>, linux-soc@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is
 used alone

Hi Rob,


2016-03-08 17:49 GMT+09:00 Rob Herring <robh+dt@...nel.org>:
> On Mon, Mar 7, 2016 at 11:46 PM, Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
>> The compatible string "simple-bus" is well defined in ePAPR, while
>> I see no documentation for the "arm,amba-bus" in ePAPR or under
>> Documentation/devicetree/.
>>
>> DT is also used by other projects than Linux kernel.  It is not a
>> good idea to rely on such an unofficial binding.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> ---
>>
>> Changes in v2:
>>   - Rephrase the git-log
>
> [...]
>
>> diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi
>> index ea288f0..8da4582 100644
>> --- a/arch/arm/boot/dts/axm55xx.dtsi
>> +++ b/arch/arm/boot/dts/axm55xx.dtsi
>> @@ -107,7 +107,7 @@
>>                 };
>>
>>                 amba {
>> -                       compatible = "arm,amba-bus";
>> +                       compatible = "arm,amba-bus", "simple-bus";
>
> As I mentioned in the last version, I think you should remove
> arm,amba-bus and just have simple-bus. I don't believe anything relies
> on having arm,amba-bus.

Sorry about this.

V3 is here now:
https://patchwork.kernel.org/patch/8542031/




-- 
Best Regards
Masahiro Yamada