linux-kernel - Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANcMJZAONMxfht8W5oGR7nnNvw9ac9hpDKekvcXbo6UM20auQw@mail.gmail.com>
Date:	Wed, 9 Mar 2016 14:55:17 +0700
From:	John Stultz <john.stultz@...aro.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Ulf Hansson <ulf.hansson@...aro.org>,
	Seshagiri Holi <sholi@...dia.com>,
	Jon Hunter <jonathanh@...dia.com>, linux-mmc@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl

On Mon, Mar 7, 2016 at 1:59 PM, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> We should return -EINVAL if cmd is not MMC_IOC_CMD or MMC_IOC_MULTI_CMD,
> otherwise blkdev_roset will return -EPERM.
>
> Android-adb calls make_block_device_writable with ioctl(BLKROSET), which
> will return error, make remount failed:
> remount of /system failed;
> couldn't make block device writable: Operation not permitted
>
> openat(AT_FDCWD, "/dev/block/platform/ff420000.dwmmc/by-name/system", O_RDONLY) = 3
> ioctl(3, BLKROSET, 0)  = -1 EPERM (Operation not permitted)
>
> Fixes: a5f5774c55a2 ("mmc: block: Add new ioctl to send multi commands")
> Cc: stable@...r.kernel.org
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>


Ulf,
   We're hitting this as well, and Shawn's patch seems to fix it for me.

Tested-by: John Stultz <john.stultz@...aro.org>

Thanks Shawn!
-john