linux-kernel - Re: klp: remove superfluous errors in asm/livepatch.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160309100644.GI10940@pathway.suse.cz>
Date:	Wed, 9 Mar 2016 11:06:44 +0100
From:	Petr Mladek <pmladek@...e.com>
To:	Jessica Yu <jeyu@...hat.com>
Cc:	Jiri Kosina <jikos@...nel.org>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Miroslav Benes <mbenes@...e.cz>, sjenning@...hat.com,
	vojtech@...e.com, mpe@...erman.id.au,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: klp: remove superfluous errors in asm/livepatch.h

On Tue 2016-03-08 16:28:20, Jessica Yu wrote:
> >On Fri, 4 Mar 2016, Josh Poimboeuf wrote:
> >>While we're at it, do we even need the '#ifdef CONFIG_LIVEPATCH' in
> >>these files?  And in include/linux/livepatch.h?
> >
> >You are right, this seems indeed completely unnecessary. I'll remove it
> >for 4.6 as well, if noone has any objections.
> 
> Hm, I should've caught this earlier, but the notifier cleanup patch
> that removes the livepatch module notifier had kernel/module.c include
> livepatch.h for the klp_module_{coming,going} function stubs in the
> !CONFIG_LIVEPATCH case. See here: https://lkml.org/lkml/2016/2/8/1182

Great catch! And you are in time because Mirek has vacation this week :-)

> Looking back, I now don't think it makes sense for module.c to include
> all those livepatch definitions in the first place, since all it
> needed was the klp_module_{coming,going} declarations. I guess my
> question is, since we've removed the #ifdef CONFIG_LIVEPATCH blocks
> from livepatch.h, where might be a better place for the
> klp_module_{coming,going} stubs? Perhaps they could go in module.h
> instead?

I personally prefer to keep the klp_module_{coming,going} declarations
in livepatch.h. It means to keep the '#ifdef CONFIG_LIVEPATCH' there
as well. It is a standard solution. It helps to find things where
one would expect them.

Best Regards,
Petr