linux-kernel - Re: [RFC 5/7] wlcore: avoid fragile snprintf use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8760wvswg7.fsf@kamboji.qca.qualcomm.com>
Date:	Wed, 09 Mar 2016 13:49:12 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Kees Cook <keescook@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 5/7] wlcore: avoid fragile snprintf use

Rasmus Villemoes <linux@...musvillemoes.dk> writes:

> Appending to a buffer like this is not guaranteed to work (passing
> overlapping src and dst buffers to snprintf is undefined
> behaviour). The standard and safe idiom is to keep track of the
> current string length.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Should I take this or what's the plan?

-- 
Kalle Valo