linux-kernel - Re: [PATCH 09/11] tools/objtool: Copy hashtable.h into tools directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160309160941.GA21308@treble.redhat.com>
Date:	Wed, 9 Mar 2016 10:09:41 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 09/11] tools/objtool: Copy hashtable.h into tools
 directory

On Wed, Mar 09, 2016 at 10:47:59AM +0100, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> 
> > Copy hashtable.h from include/linux/tools.h.  It's needed by objtool in
> > the next patch in the series.
> > 
> > Add some includes that it needs, and remove references to
> > kernel-specific features like RCU and __read_mostly.
> > 
> > Also change some if its dependency headers' includes to use quotes
> > instead of brackets so gcc can find them.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > ---
> >  tools/include/asm-generic/bitops/__fls.h |   2 +-
> >  tools/include/asm-generic/bitops/fls.h   |   2 +-
> >  tools/include/asm-generic/bitops/fls64.h |   2 +-
> >  tools/include/linux/hashtable.h          | 152 +++++++++++++++++++++++++++++++
> >  4 files changed, 155 insertions(+), 3 deletions(-)
> 
> So it would be nice to also add a build time warning if the 'upstream' copy of 
> hashtable.h deviates from the tooling file.
> 
> Just like you are already doing it for other files:
> 
> objtool/Makefile:       diff -I'^#include' arch/x86/insn/insn.c ../../arch/x86/lib/insn.c >/dev/null && \
> 
> Btw., eventually we might want to factor out such duplication into a single place 
> in tools/lib/ or so, to only have a 'master copy' (upstream kernel source), and 
> the tooling copy.

Yeah, since we already have at least two instances of this type of
diffing in the tools tree, it would be good to generalize these diffs in
a common place with a common kernel build target.  I'll add it to my
TODOs.

BTW, do you know why the policy is to copy them instead of just
including the kernel versions?

If the goal is to make it easier to package the tools separately,
wouldn't something like the perf MANIFEST file make that possible
without copying?

Or if the goal is only to make it possible to compile kernel headers in
user space, then we may only need to copy or recreate some headers and I
may have been overzealous with my copying.

-- 
Josh