linux-kernel - Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551d9d1ae5418dd2dfa91aa6db69deb9.squirrel@us.codeaurora.org>
Date:	Wed, 9 Mar 2016 20:52:59 -0000
From:	ygardi@...eaurora.org
To:	"Greg KH" <gregkh@...uxfoundation.org>
Cc:	ygardi@...eaurora.org, james.bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org,
	"Dolev Raviv" <draviv@...eaurora.org>,
	"Gilad Broner" <gbroner@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...n.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"Michael Neuling" <mikey@...ling.org>,
	"Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>,
	"Wen Xiong" <wenxiong@...ux.vnet.ibm.com>,
	"Subhash Jadavani" <subhashj@...eaurora.org>,
	"open list:ABI/API" <linux-api@...r.kernel.org>
Subject: Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

> On Wed, Mar 09, 2016 at 07:09:49PM -0000, ygardi@...eaurora.org wrote:
>> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote:
>> >> This patch exposes the ioctl interface for UFS driver via SCSI device
>> >> ioctl interface. As of now UFS driver would provide the ioctl for
>> query
>> >> interface to connected UFS device.
>> >>
>> >> Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>
>> >> Signed-off-by: Dolev Raviv <draviv@...eaurora.org>
>> >> Signed-off-by: Gilad Broner <gbroner@...eaurora.org>
>> >> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>
>> >
>> > What tool is going to use this ioctl?  Why does userspcae want to do
>> > something "special" with UFS devices?  Shouldn't they just be treated
>> > like any other normal block device?
>> >
>>
>> Any userspace application can be a tool.
>> We already implemented and used a user space application, that sent
>> queries to the UFS devices in order to get information and descriptors.
>
> But do you want to do with that information?  Why does userspace care?
>

i don't really understand the subtext of your question -
as ANY ioctl cb, we decided to implement the ioctl callback of this scsi
device in order to get information like UNIT DESC, DEVICE DESC, FLAGs,
ATTRIBUTES.
When dealing with UFS devices, one should be able to read the
characteristics of the device. why ? well, why not ?
during development of this driver, it was useful in many cases to be able
to communicate with the device, by simple IOCTL command, rather than
implementing ad-hock.

regards,
Yaniv

>> Not only ioctl interface is a useful way to interact with the device,
>> we used it, and found it very helpful in varies cases.
>
> In what case was it helpful?  Why does userspace care about ufs
> specifics, it should just treat it like any other block device and not
> care at all.
>
> thanks,
>
> greg k-h
>