linux-kernel - Re: [PATCH 01/13] hwmon: convert lm75 to use devm_thermal_zone_of_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E0E7A0.2080202@roeck-us.net>
Date:	Wed, 9 Mar 2016 19:18:56 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Eduardo Valentin <edubezval@...il.com>,
	Rui Zhang <rui.zhang@...el.com>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, lm-sensors@...sensors.org,
	Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH 01/13] hwmon: convert lm75 to use
 devm_thermal_zone_of_sensor_register

On 03/09/2016 01:35 PM, Eduardo Valentin wrote:
> This changes the driver to use the devm_ version
> of thermal_zone_of_sensor_register and cleans
> up the  local points and unregister calls.
>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: lm-sensors@...sensors.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@...il.com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/hwmon/lm75.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 0addc84..69166ab 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -77,7 +77,6 @@ static const u8 LM75_REG_TEMP[3] = {
>   struct lm75_data {
>   	struct i2c_client	*client;
>   	struct device		*hwmon_dev;
> -	struct thermal_zone_device	*tz;
>   	struct mutex		update_lock;
>   	u8			orig_conf;
>   	u8			resolution;	/* In bits, between 9 and 12 */
> @@ -306,11 +305,9 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
>   	if (IS_ERR(data->hwmon_dev))
>   		return PTR_ERR(data->hwmon_dev);
>
> -	data->tz = thermal_zone_of_sensor_register(data->hwmon_dev, 0,
> -						   data->hwmon_dev,
> -						   &lm75_of_thermal_ops);
> -	if (IS_ERR(data->tz))
> -		data->tz = NULL;
> +	devm_thermal_zone_of_sensor_register(data->hwmon_dev, 0,
> +					     data->hwmon_dev,
> +					     &lm75_of_thermal_ops);
>
>   	dev_info(dev, "%s: sensor '%s'\n",
>   		 dev_name(data->hwmon_dev), client->name);
> @@ -322,7 +319,6 @@ static int lm75_remove(struct i2c_client *client)
>   {
>   	struct lm75_data *data = i2c_get_clientdata(client);
>
> -	thermal_zone_of_sensor_unregister(data->hwmon_dev, data->tz);
>   	hwmon_device_unregister(data->hwmon_dev);
>   	lm75_write_value(client, LM75_REG_CONF, data->orig_conf);
>   	return 0;
>