linux-kernel - Re: [PATCH 03/13] hwmon: convert tmp102 to use devm_thermal_zone_of_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E0E7FA.4030400@roeck-us.net>
Date:	Wed, 9 Mar 2016 19:20:26 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Eduardo Valentin <edubezval@...il.com>,
	Rui Zhang <rui.zhang@...el.com>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, lm-sensors@...sensors.org,
	Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH 03/13] hwmon: convert tmp102 to use
 devm_thermal_zone_of_sensor_register

On 03/09/2016 01:35 PM, Eduardo Valentin wrote:
> This changes the driver to use the devm_ version
> of thermal_zone_of_sensor_register and cleans
> up the  local points and unregister calls.
>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: lm-sensors@...sensors.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@...il.com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/hwmon/tmp102.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
> index 5289aa0..f1e96fd 100644
> --- a/drivers/hwmon/tmp102.c
> +++ b/drivers/hwmon/tmp102.c
> @@ -53,7 +53,6 @@
>   struct tmp102 {
>   	struct i2c_client *client;
>   	struct device *hwmon_dev;
> -	struct thermal_zone_device *tz;
>   	struct mutex lock;
>   	u16 config_orig;
>   	unsigned long last_update;
> @@ -232,10 +231,8 @@ static int tmp102_probe(struct i2c_client *client,
>   		goto fail_restore_config;
>   	}
>   	tmp102->hwmon_dev = hwmon_dev;
> -	tmp102->tz = thermal_zone_of_sensor_register(hwmon_dev, 0, hwmon_dev,
> -						     &tmp102_of_thermal_ops);
> -	if (IS_ERR(tmp102->tz))
> -		tmp102->tz = NULL;
> +	devm_thermal_zone_of_sensor_register(hwmon_dev, 0, hwmon_dev,
> +					     &tmp102_of_thermal_ops);
>
>   	dev_info(dev, "initialized\n");
>
> @@ -251,7 +248,6 @@ static int tmp102_remove(struct i2c_client *client)
>   {
>   	struct tmp102 *tmp102 = i2c_get_clientdata(client);
>
> -	thermal_zone_of_sensor_unregister(tmp102->hwmon_dev, tmp102->tz);
>   	hwmon_device_unregister(tmp102->hwmon_dev);
>
>   	/* Stop monitoring if device was stopped originally */
>