linux-kernel - Re: [patch net 1/2] net: hns: fix return value of the function about rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1457597509.1347.49.camel@linux.intel.com>
Date:	Thu, 10 Mar 2016 10:11:49 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Kejian Yan <yankejian@...wei.com>, davem@...emloft.net
Cc:	yisen.zhuang@...wei.com, salil.mehta@...wei.com,
	liguozhu@...wei.com, huangdaode@...ilicon.com, arnd@...db.de,
	andrew@...n.ch, chenny.xu@...wei.com, ivecera@...hat.com,
	lisheng011@...wei.com, fengguang.wu@...el.com,
	haifeng.wei@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linuxarm@...wei.com
Subject: Re: [patch net 1/2] net: hns: fix return value of the function
 about rss

On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote:
> Both .get_rxfh and .get_rxfh are always return 0, it should return
> result
> from hardware when getting or setting rss. And the rss function
> should
> return the correct data type.
> 

@@ -1213,7 +1213,7 @@ hns_get_rss(struct net_device *netdev, u32
> *indir, u8 *key, u8 *hfunc)
>  
> 

>  	ret = ops->get_rss(priv->ae_handle, indir, key, hfunc);
>  
> -	return 0;
> +	return ret;

All three can be one line.

> @@ -1241,7 +1241,7 @@ hns_set_rss(struct net_device *netdev, const
> u32 *indir, const u8 *key,
>  
>  	ret = ops->set_rss(priv->ae_handle, indir, key, hfunc);
>  
> -	return 0;
> +	return ret;

Ditto.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy