linux-kernel - Re: [PATCHSET 0/7] perf tools: Fix and cleanups for hierarchy mode (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160310103336.GC11206@krava.redhat.com>
Date:	Thu, 10 Mar 2016 11:33:36 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCHSET 0/7] perf tools: Fix and cleanups for hierarchy mode
 (v2)

On Wed, Mar 09, 2016 at 10:46:55PM +0900, Namhyung Kim wrote:
> Hello,
> 
> These are filter-related fixes and cleanups in the new hierarchy mode.
> Currently perf misbehaves in hierarchy mode when filter is applied.
> For example, it sometimes misses some (upper level) entries in the
> output or shows incorrect (very large) overhead.
> 
>  * Changes in v2)
>   - update hist_entry__filter() to check multiple filters properly
>   - add missing runtime filter check when adding hierarchy entries
>   - recalculate total period using top-level entries  (Jiri)
>   - add more comment
>   
> 
> Before:
> 
>   $ perf report --hierarchy -s 'cpu,{dso,comm}' --comms swapper --stdio
>   ...
>   #    Overhead  CPU / Shared Object+Command
>   # ...........  ...........................
>   #
>          13.79%     [kernel.vmlinux]  swapper
>       31.71%     000
>          13.80%     [kernel.vmlinux]  swapper
>           0.43%     [e1000e]          swapper
>          11.89%     [kernel.vmlinux]  swapper
>           9.18%     [kernel.vmlinux]  swapper
>     
> After:
> 
>   #    Overhead  CPU / Shared Object+Command
>   # ...........  ...............................
>   #
>       33.09%     003
>          13.79%     [kernel.vmlinux]  swapper
>       31.71%     000
>          13.80%     [kernel.vmlinux]  swapper
>           0.43%     [e1000e]          swapper
>       21.90%     002
>          11.89%     [kernel.vmlinux]  swapper
>       13.30%     001
>           9.18%     [kernel.vmlinux]  swapper
> 
> 
> It's also available on 'perf/hierarchy-filter-v2' branch in my tree
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> any feedback are welcome.

looks good to me, the 'F' toggle shows sane number for me now

Acked-and-tested-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka