linux-kernel - Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E17A73.8090901@bitmath.org>
Date:	Thu, 10 Mar 2016 14:45:23 +0100
From:	Henrik Rydberg <rydberg@...math.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Aniroop Mathur <a.mathur@...sung.com>
Cc:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Aniroop Mathur <aniroop.mathur@...il.com>
Subject: Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet
 data

Hi Dmitry,

>> diff --git a/drivers/input/input.c b/drivers/input/input.c
>> index 8806059..262ef77 100644
>> --- a/drivers/input/input.c
>> +++ b/drivers/input/input.c
>> @@ -401,8 +401,7 @@ static void input_handle_event(struct input_dev *dev,
>>                 if (dev->num_vals >= 2)
>>                         input_pass_values(dev, dev->vals, dev->num_vals);
>>                 dev->num_vals = 0;
>> -       } else if (dev->num_vals >= dev->max_vals - 2) {
>> -               dev->vals[dev->num_vals++] = input_value_sync;
>> +       } else if (dev->num_vals >= dev->max_vals - 1) {
>>                 input_pass_values(dev, dev->vals, dev->num_vals);
>>                 dev->num_vals = 0;
>>         }
> 
> This makes sense to me. Henrik?

I went through the commits that made these changes, and I cannot see any strong
reason to keep it. However, this code path only triggers if no SYN events are
seen, as in a driver that fails to emit them and consequently fills up the
buffer. In other words, this change would only affect a device that is already,
to some degree, broken.

So, the question to Aniroop is: do you see this problem in practise, and in that
case, for what driver?

Henrik