linux-kernel - Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E17F0A.7060608@redhat.com>
Date:	Thu, 10 Mar 2016 15:04:58 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:	huaitong.han@...el.com
Subject: Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from
 permission_fault



On 10/03/2016 15:03, Xiao Guangrong wrote:
> 
> 
> On 03/08/2016 07:45 PM, Paolo Bonzini wrote:
>> Intel's new PKU extension introduces a bit of the page fault error code
>> that must be dynamically computed after the PTE lookup (unlike I/D, U/S
>> and W/R).  To ease this, these two patches make permission_fault return
>> the page fault error code.
>>
>> Right now it only adds the P bit to the input parameter "pfec", but PKU
>> can change that.
> 
> Yep, i got the same idea when i reviewed the pkey patchset. This patch
> looks good to me.
> 
> Reviewed-by: Xiao Guangrong <guangrong.xiao@...ux.intel.com>

Great, feel free to pick it up in the pkey patchset.  I'm answering to
1/2 now.

Paolo