linux-kernel - Re: + x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160310143903.GF2464@linux.intel.com>
Date:	Thu, 10 Mar 2016 09:39:03 -0500
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	akpm@...ux-foundation.org, hpa@...or.com, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	Andrea Arcangeli <aarcange@...hat.com>
Subject: Re: +
 x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch
 added to -mm tree

On Thu, Mar 10, 2016 at 10:37:50AM +0100, Ingo Molnar wrote:
> > > > It seems unfair to ask me to do better than what is there right now.
> > > 
> > > It's absolutely fair for maintainers to require the improvement of existing code 
> > > you want to modify, especially when you are complicating existing code ...
> > 
> > I'm not complicating it.  I'm duplicating it.
> 
> I don't think your language lawyering is particularly constructive: you are adding 
> new functionality to existing x86 code, and as such you need to address review 
> feedback from x86 maintainers - even if it involves old code.

Absolutely.  But if I've just copied-and-pasted code from elsewhere in
the same file, then I have no obligation to fix style problems.  Indeed,
with the variety of styles throughout the kernel, following local style
is clearly the right thing to do for someone who is at best an occasional
contributor to a particular file.

> Anyway, until my concerns are addressed the x86 bits are NAK-ed:
> 
>   NAKed-by: Ingo Molnar <mingo@...nel.org>

You're adorable.  You'd reject this feature over the format of a comment
that you don't like.  And you'd rather argue about whether I should fix
the comment than review the patch elsewhere in this thread where I remove
the need for the comment.

It's a good thing Andrea is constructive.