linux-kernel - [tip:irq/core] irqchip/mxs: Fix error check of of_io_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-edf8fcdc6b254236be005851af35ea5e826e7e09@git.kernel.org>
Date:	Thu, 10 Mar 2016 07:06:58 -0800
From:	tip-bot for Vladimir Zapolskiy <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	tglx@...utronix.de, marc.zyngier@....com, shawnguo@...nel.org,
	linux@...pel-privat.de, jason@...edaemon.net, mingo@...nel.org,
	hpa@...or.com, kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	vz@...ia.com
Subject: [tip:irq/core] irqchip/mxs: Fix error check of
 of_io_request_and_map()

Commit-ID:  edf8fcdc6b254236be005851af35ea5e826e7e09
Gitweb:     http://git.kernel.org/tip/edf8fcdc6b254236be005851af35ea5e826e7e09
Author:     Vladimir Zapolskiy <vz@...ia.com>
AuthorDate: Wed, 9 Mar 2016 03:21:40 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 10 Mar 2016 16:03:30 +0100

irqchip/mxs: Fix error check of of_io_request_and_map()

The of_io_request_and_map() returns a valid pointer in iomem region or
ERR_PTR(), check for NULL always fails and may cause a NULL pointer
dereference on error path.

Fixes: 25e34b44313b ("irqchip/mxs: Prepare driver for hardware with different offsets")
Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: Oleksij Rempel <linux@...pel-privat.de>
Cc: Sascha Hauer <kernel@...gutronix.de>
Cc: Shawn Guo <shawnguo@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org
Link: http://lkml.kernel.org/r/1457486500-10237-1-git-send-email-vz@mleia.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/irqchip/irq-mxs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index efe5084..1730470 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -183,7 +183,7 @@ static void __iomem * __init icoll_init_iobase(struct device_node *np)
 	void __iomem *icoll_base;
 
 	icoll_base = of_io_request_and_map(np, 0, np->name);
-	if (!icoll_base)
+	if (IS_ERR(icoll_base))
 		panic("%s: unable to map resource", np->full_name);
 	return icoll_base;
 }